1005114 - Profile includes list of completed tasks

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Rebecca Billings [:rbillings]]

After a user has completed a task, it should display on their profile. 
- List the most recently completed task at the top, display is in descending order
- Link to the task details

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Assigning this P1. It was the top pick of One and Done users and the QA community team.

Maja, would you like to work on this? It strikes me as being fairly straightforward. If you want to tackle it, you can assign the bug to yourself :) We can dive into discussion of it whenever you like.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

For reference, here are the version 1 designs of the profile that pragmatic came up with, for edit mode and for view mode. 

https://wiki.mozilla.org/QA/Taskboard/Workflows/Contributors#Edit_Profile_Page
https://wiki.mozilla.org/QA/Taskboard/Workflows/Contributors#Profile_Page

Comment 3

[Rebecca Billings [:rbillings]]

Attachment: Completed tasks dashboard.png

Attached a view of the User's Profile with completed tasks. This feature focuses solely on the profile view, and the completed tasks.

Comment 4

[Rebecca Billings [:rbillings]]

Attachment: Completed tasks profile.rtf

•	Breadcrumbs go to unique username profile page
	•	O&D logo in upper left corner
	•	Username’s Profile header
	•	Remove ‘Contribute to Mozilla QA’ box
	•	Display title of task in progress, with link to task detail page
	•	Display total number of tasks completed
	•	Display tasks in descending order, with most recently completed task at the top
	•	Add pagination buttons after user has completed 20 tasks
	•	Keep Edit Profile button
	•	Keep Pick a Task button

Comment 5

[Rebecca Billings [:rbillings]]

* Username profile page name and location matches username

Comment 7

[Rebecca Billings [:rbillings]]

Update: The unique username profile page will go to a User ID, not the username. The unique ID will link to the user's email address within Admin. This way users may change their display name without changing their profile link.

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

When is the profile page encountered during the user's visit? I see two main options: 4a and 4b, below. 

Flow
1. One and Done front page
2. User signs in
3. If user has no profile, show Create Profile form
4a. Show One and Done front page again (signed in version, with dashboard)

OR

4b. Show user profile

Comment 9

[Bob Silverberg [:bsilverberg]]

Maja, as discussed in our meeting this morning, the profile page described by this bug is the same as the current "dashboard". That may change, but any changes that are made to the dashboard can easily be carried over to a new profile page if and when we need it.

Comment 10

[Bob Silverberg [:bsilverberg]]

Maja pointed out the the wireframes contradict my comment above, so I will put this back in Rebecca's court. How would a user encounter the Profile page?

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Comment 12

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Great work Maja! It's an excellent first iteration.

Once you've done addressing my comments in the PR flag me again for review. You don't need to add an attachment again for that. Just use this same attachment and set the review flag for me back to '?'.

Comment 13

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Thanks for the detailed review, Bob. I believe I have addressed all your comments.

Comment 14

[Pankaj Malhotra (:bitgeeky)]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Bob is looking into this :-)

Comment 15

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Just one small nit, but I'd also like to see an attempt at encapsulating the pagination template in this pull request.

Also, when you flag me for re-review, use the same "column" in the attachment details as opposed to adding a new one. You just change my r- to a r? and type my name again in the input box beside it.

Comment 16

[Rebecca Billings [:rbillings]]

The User Profile page is displayed upon account creation, and upon login- matching current functionality.

1. One and Done front page
2. User signs in
3. If user has no profile, show Create Profile form
4b. If user has profile, Show user profile

There is a front page and a profile - both with "dashboards" so that term is confusing. The dashboard is what I'm thinking of as the box showing the tasks in progress or that have been completed.

Comment 17

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Thanks Rebecca, that clears things up for me. 

The user profile is quite bare for new users. (All it displays is a box that states "0 tasks completed" i.e. just the dashboard.) For this reason, I suggest that showing the "front-page-with-dashboard" at step 4b might be better for now. 
Down the line, I imagine the user profile will display more than just a summary of recent activity.

(In reply to Rebecca Billings [:rbillings] from comment #16)
> 1. One and Done front page
> 2. User signs in
> 3. If user has no profile, show Create Profile form
> 4b. If user has profile, Show user profile
> There is a front page and a profile - both with "dashboards"

Comment 18

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Pagination isn't working with Available Tasks when filtered.

Comment 19

[Rebecca Billings [:rbillings]]

Based on the meeting discussion today, we are taking Maja's suggestion:

1) Log in
2) If no profile, show create profile form
3) If user has a profile, log in user and display front page including mini-dashboard showing task in progress

Comment 20

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

We need a different solution to the filtered-paging issue, I think. See the PR for comments.

Comment 21

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

I really appreciate your detailed feedback, Bob. Thanks for taking the time to discuss. 

The issue with pagination URLs is actually in master. I updated the tests to highlight the problem and show how my changes handle it. I suggest that a separate bug should be opened about the pagination URL -- please see my comments on the pull request.

Comment 22

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8430832 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/120

Sorry, but the branch needs to be fixed, removing all those extra commits. I have also asked Osmose for his opinion about the pagination/url thing as he wrote the initial code and I am not comfortable changing it without checking with him first for repercussions.

Comment 23

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/124

Replacing previous pull request with one that's been cleaned up. The contributions in this new PR are the same as before, so Comment 21 still applies. 

Thanks for advice on how to deal with the messy pull request disaster, Bob. Very sorry about that.

Comment 24

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8434252 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/124

Looks great, maja. Just requesting a final review from Osmose.

Comment 25

[Bob Silverberg [:bsilverberg]]

Landed in https://github.com/mozilla/oneanddone/commit/52e4d7a983ddeb2bb58c6db213b5c3a9f3038259

Comment 26

[Rebecca Billings [:rbillings]]

Verified profile shows completed tasks